qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3280: Performance problem with TTL messages.
Date Fri, 10 Jun 2011 21:18:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/791/
-----------------------------------------------------------

(Updated 2011-06-10 21:18:44.812882)


Review request for qpid, Andrew Stitcher, Alan Conway, Gordon Sim, and Andy Goldstein.


Changes
-------

Hopefully the last patch in this series.


Summary (updated)
-------

QPID-3280: Performance problem with TTL messages.

When sending a large number of messages with nonzero TTLs to a
cluster, overall message throughput drops by around 20-30% compared to
messages with TTL 0.

The previous approach to TTL in the cluster is replaced with a simpler
"cluster clock". Also QueueCleaner is executed in the cluster timer,
and modified to be deterministic in a cluster.


Diffs (updated)
-----

  /trunk/qpid/cpp/include/qpid/framing/FieldTable.h 1134238 
  /trunk/qpid/cpp/src/CMakeLists.txt 1134238 
  /trunk/qpid/cpp/src/Makefile.am 1134238 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.h 1134238 
  /trunk/qpid/cpp/src/qpid/broker/ExpiryPolicy.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/broker/Message.h 1134238 
  /trunk/qpid/cpp/src/qpid/broker/Message.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/broker/Queue.h 1134238 
  /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1134238 
  /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/broker/RateTracker.h 1134238 
  /trunk/qpid/cpp/src/qpid/broker/RateTracker.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.h 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterPlugin.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterSettings.h 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.h 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/ExpiryPolicy.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.h 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/FailoverExchange.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1134238 
  /trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.h 1134238 
  /trunk/qpid/cpp/src/qpid/sys/Timer.h 1134238 
  /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1134238 
  /trunk/qpid/cpp/src/tests/QueueTest.cpp 1134238 
  /trunk/qpid/cpp/src/tests/cluster_test_logs.py 1134238 
  /trunk/qpid/cpp/src/tests/cluster_tests.py 1134238 
  /trunk/qpid/cpp/xml/cluster.xml 1134238 

Diff: https://reviews.apache.org/r/791/diff


Testing
-------


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message