qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3200: cumulative acknowledgement up to a specified point
Date Tue, 14 Jun 2011 12:23:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review831
-----------------------------------------------------------

Ship it!


- Alan


On 2011-06-10 16:27:29, Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/882/
> -----------------------------------------------------------
> 
> (Updated 2011-06-10 16:27:29)
> 
> 
> Review request for qpid.
> 
> 
> Summary
> -------
> 
> This patch adds a new method to the qpid::messaging::Session class in the public API
that allows all messages up to a certain point to be acknowledged.
> 
> 
> This addresses bug QPID-3200.
>     https://issues.apache.org/jira/browse/QPID-3200
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822 
>   /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102 
> 
> Diff: https://reviews.apache.org/r/882/diff
> 
> 
> Testing
> -------
> 
> All existing tests pass, new test added to cover the new method.
> 
> 
> Thanks,
> 
> Gordon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message