qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3044) Implement JCA Adapter for Java JMS client
Date Thu, 14 Jul 2011 22:24:04 GMT

    [ https://issues.apache.org/jira/browse/QPID-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065573#comment-13065573
] 

jiraposter@reviews.apache.org commented on QPID-3044:
-----------------------------------------------------



bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java,
line 48
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13133#file13133line48>
bq.  >
bq.  >     "QPID-CF" should be external constant 
bq.  >     r.get() result not checked for null

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java,
line 127
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13137#file13137line127>
bq.  >
bq.  >     "QPID-CF" should be external constant

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
line 324
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line324>
bq.  >
bq.  >     null check is redundant, since instanceof will return false for a null value
of obj

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
line 349
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line349>
bq.  >
bq.  >     hashCode does not meet Object contract with equals and should include clientId
in calculation

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
line 355
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line355>
bq.  >
bq.  >     can just use type here?

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
line 357
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line357>
bq.  >
bq.  >     can just use acknowledgeMode here?

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
line 304
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line304>
bq.  >
bq.  >     null check is redundant, due to use of instanceof

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
line 321
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line321>
bq.  >
bq.  >     null check redundant, due to instanceof

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.  > /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java, line
176
bq.  > <https://reviews.apache.org/r/441/diff/3/?file=13141#file13141line176>
bq.  >
bq.  >     do we really want to use Object's toString here?

On balance we've decided to leave it as is for now, it does no real harm.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/#review298
-----------------------------------------------------------


On 2011-02-24 15:12:05, Andrew Stitcher wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/441/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-02-24 15:12:05)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Review for a qpid JCA resource adapter.
bq.  
bq.  So far no build infrastructure is included.
bq.  
bq.  I'd also like an opinion as to whether java/jca is the appropriate name for this (I'm
thinking perhaps java/ra would be more usual).
bq.  
bq.  Any and all comments welcome.
bq.  
bq.  
bq.  This addresses bug QPID-3044.
bq.      https://issues.apache.org/jira/browse/QPID-3044
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
PRE-CREATION 
bq.    /trunk/qpid/java/build.deps 1070497 
bq.    /trunk/qpid/java/build.xml 1070497 
bq.    /trunk/qpid/java/jca/build.xml PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION

bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
PRE-CREATION 
bq.    /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION 
bq.    /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN 
bq.    /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN 
bq.  
bq.  Diff: https://reviews.apache.org/r/441/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Andrew
bq.  
bq.



> Implement JCA Adapter for Java JMS client
> -----------------------------------------
>
>                 Key: QPID-3044
>                 URL: https://issues.apache.org/jira/browse/QPID-3044
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Client
>    Affects Versions: 0.8, 0.9, 0.10
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>              Labels: JCA, JMS, Java, qpid
>             Fix For: 0.11
>
>
> Currently there is no way to integrate the use of Qpid messaging into a Java
> Application Server.
> The solution is to create a JCA (J2EE Connector Architecture) adapter to allow
> the Qpid JMS client to correctly work with the J2EE container.
> This is an entirely new Java component, but may require small amounts of change to the
> JMS client code.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message