qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddhesh Poyarekar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-3368) Check for dirty session after failover during commit() not in the correct place
Date Thu, 21 Jul 2011 01:31:57 GMT

     [ https://issues.apache.org/jira/browse/QPID-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Siddhesh Poyarekar updated QPID-3368:
-------------------------------------

    Attachment: qpid-java-check-failover.patch

The patch. Changes in this patch:

* Created commitImpl that acknowledges messages. This is overridden in AMQSession_0_10
* removed the rollback() call in case of failover. It's going to fail anyway since the old
session is gone.

> Check for dirty session after failover during commit() not in the correct place
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3368
>                 URL: https://issues.apache.org/jira/browse/QPID-3368
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.10
>            Reporter: Siddhesh Poyarekar
>            Priority: Minor
>              Labels: patch
>         Attachments: TxFailover.java, qpid-java-check-failover.patch
>
>
> When a session is committed after failover using the session.commit() call, it incorrectly
throws a RuntimeException (SessionException). It should throw a JMSException instead so that
the client can recover.
> org.apache.qpid.client.AMQSession has a check for failover in its commit method, but
this method is overridden in org.apache.qpid.client.AMQSession_0_10 and the latter does not
have the failover check. As a result, the check is never used. I have attached a patch that
reworks the code a bit to allow org.apache.qpid.client.AMQSession_0_10 to use the failover
check during commit.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message