qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen" <cliffjan...@gmail.com>
Subject Re: Review Request: Keeps track of Qpid runnable threads and other threads, ensuring that rundown doesn't deadlock.
Date Tue, 05 Jul 2011 17:54:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/987/
-----------------------------------------------------------

(Updated 2011-07-05 17:54:17.154114)


Review request for qpid.


Changes
-------

Now uses Thread local storage (TLS) instead of a std::map to locate the ThreadPrivate structure.
DllMain baggage still there to manage the FreeLibrary case.


Summary
-------

This is the same logic as the preceding version with naming fixes and refinements to DLL cleanup.

Cleanup now uses Windows DllMain function to allows cleanup after C++ runtime static destructors.


This addresses bug qpid-3256.
    https://issues.apache.org/jira/browse/qpid-3256


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1143151 

Diff: https://reviews.apache.org/r/987/diff


Testing
-------

Qpid cmake run_tests


Thanks,

Cliff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message