qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3342) Rationalise transport layer by introducing common interfaces shared by all protocols
Date Thu, 07 Jul 2011 19:42:17 GMT

    [ https://issues.apache.org/jira/browse/QPID-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061533#comment-13061533
] 

Robbie Gemmell commented on QPID-3342:
--------------------------------------

Hi Rajith

Im sorry you feel that way, and have to say I disagree in general, but as some attempt at
explanation:

This is as mentioned above, very much in line with the work Andrew was doing previously so
its design has as you mention been proposed, and has had the previous code available on branches
for close to 9 months now. Given this, despite this being a reimplementation (involving less
change in a more controlled fashion), I dont think this is entirely out of the blue and it
seems like ample discussion had taken place and time to consider it been given.

I can conceed your point about possibly putting it up for review first, although I would usually
only take course for something that hadnt been given prior discussion, hadnt had any review,
and had some doubt about it. I would stress that this (and Andrews code before it) has already
seen *weeks* of review from myself before I committed it, and again the previous implemtnation
has been available for all to look at. Great care was taken to try and ensure consistency
of the IO behaviour during the restructuring (which was actually fairly minimal for the 0-10
code path), and no IO features which were present and worked or were being used are being
(permanantly) removed. Much of the change that went in was nothing to do with the IO layer
alongside work, and is purely to the Java broker or associated dead Mina related features.

The transports are *not* currently configurable, however as I mentioned above they will again
be made so via a final JIRA (quite possibly tomorrow), in similar fashion to the way they
were already. I didn't think this small delay was a particular sticking point for the rest
of the code given that until these changes were made there were no two interface-compatible
IO implementations available to use such plugability.

> Rationalise transport layer by introducing common interfaces shared by all protocols
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-3342
>                 URL: https://issues.apache.org/jira/browse/QPID-3342
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client, Java Common
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>             Fix For: 0.13
>
>         Attachments: 0002-QPID-3342-rationalise-the-existing-0-10-transport-co.patch,
0003-QPID-3342-transition-TCP-based-Mina-transport-for-0-.patch
>
>
> Refactor the transport stack by introducing two new interfaces NetworkTransport and NetworkConnection.
  Remove dependencies between IoSender and IoReceiver.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message