qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3346) Support message grouping with stricted sequence consumption across multiple consumers.
Date Tue, 16 Aug 2011 13:57:32 GMT

    [ https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085706#comment-13085706
] 

jiraposter@reviews.apache.org commented on QPID-3346:
-----------------------------------------------------



bq.  On 2011-08-16 09:08:13, Gordon Sim wrote:
bq.  > /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp, line 122
bq.  > <https://reviews.apache.org/r/1312/diff/2/?file=32700#file32700line122>
bq.  >
bq.  >     I don't think match should be part of the MessageAllocator interface. I think
the filter perhaps should include a filter-type identifier which can be used to determine
how the rest of the map should be interpreted.
bq.  >     
bq.  >     We may in future want to use the same filter on different types of queue, or
different filters on the same type of queue.

Yes, this can be moved out of the MessageAllocator.   Can you give me a little more detail
as to how you think the filter & filter type should be represented?  I'm thinking that
we'd create a filter predicate based on the map, and that the move/reroute/purge methods would
iterate over the messages applying the filter predicate (probably using the return value as
the predicate to the removeIf).  Does that make sense?


- Kenneth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1312/#review1472
-----------------------------------------------------------


On 2011-08-16 00:35:20, Kenneth Giusti wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1312/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-16 00:35:20)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Some initial refactoring of Queue/Consumer interface to allow for message grouping support.
 Very preliminary.
bq.  
bq.  
bq.  This addresses bug qpid-3346.
bq.      https://issues.apache.org/jira/browse/qpid-3346
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Fairshare.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Messages.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144319 
bq.    /branches/qpid-3346/qpid/specs/management-schema.xml 1144324 
bq.    /branches/qpid-3346/qpid/tests/src/py/qpid_tests/broker_0_10/management.py 1144324

bq.  
bq.  Diff: https://reviews.apache.org/r/1312/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  minimal - passes unit tests on linux.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kenneth
bq.  
bq.



> Support message grouping with stricted sequence consumption across multiple consumers.
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3346
>                 URL: https://issues.apache.org/jira/browse/QPID-3346
>             Project: Qpid
>          Issue Type: New Feature
>          Components: C++ Broker
>    Affects Versions: 0.12
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.14
>
>         Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced Consumers.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message