qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3363) broker allows unbind on default exchange
Date Tue, 09 Aug 2011 11:05:28 GMT

    [ https://issues.apache.org/jira/browse/QPID-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081565#comment-13081565
] 

jiraposter@reviews.apache.org commented on QPID-3363:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1403/
-----------------------------------------------------------

Review request for Alan Conway and Kim van der Riet.


Summary
-------

Error is now signalled as required by specification. The default exchange bindings are not
explicitly replicated to cluster members; this was redundant anyway (as the bindings are established
on creation of the queues in question) and now would cause errors.


This addresses bug QPID-3363.
    https://issues.apache.org/jira/browse/QPID-3363


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1155286 
  /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1155286 
  /trunk/qpid/cpp/src/tests/federation_sys.py 1155286 

Diff: https://reviews.apache.org/r/1403/diff


Testing
-------

New tests added. The federation_sys tests used the default exchange in an illegal manner and
this tests replaces it with amq.direct (a general purpose, preconfigured exchange that seems
more appropriate to the use case). Make check passes.


Thanks,

Gordon



> broker allows unbind on default exchange
> ----------------------------------------
>
>                 Key: QPID-3363
>                 URL: https://issues.apache.org/jira/browse/QPID-3363
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.12
>            Reporter: Gordon Sim
>            Assignee: Gordon Sim
>             Fix For: 0.13
>
>
> Rule 'default-access' states "The default exchange MUST NOT be accessible to the client
except by specifying an empty exchange name in a content publish command (such as message.transfer).
That is, the server must not let clients explicitly bind, unbind, delete, or make any other
reference to this exchange." 
> However qpid-config unbind "" my-queue my-queue will delete the binding preventing the
queue from being directly accessed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message