qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3394) Broker "leaks" messages that require async completion.
Date Thu, 04 Aug 2011 18:28:30 GMT

    [ https://issues.apache.org/jira/browse/QPID-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079515#comment-13079515
] 

jiraposter@reviews.apache.org commented on QPID-3394:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1292/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Summary
-------

Bug occurred due to state change in object -without- updating the clone of the object.   The
clone "lost" the state change, and the message was not correctly cleaned up.  This change
introduces a proper copy constructor and creates the copy after all state has been updated.


This addresses bug qpid-3394.
    https://issues.apache.org/jira/browse/qpid-3394


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1153918 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1153918 

Diff: https://reviews.apache.org/r/1292/diff


Testing
-------

in progress.


Thanks,

Kenneth



> Broker "leaks" messages that require async completion.
> ------------------------------------------------------
>
>                 Key: QPID-3394
>                 URL: https://issues.apache.org/jira/browse/QPID-3394
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.12, 0.13
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Blocker
>             Fix For: 0.12, 0.13
>
>         Attachments: membloat.patch
>
>
> The fix for QPID-3252 introduced a bug where messages that require async completion (ie.
durable, or flow controlled) are incorrectly stored by the broker until the sender sends an
explicit flush.  This can cause a excessive amount of memory to be consumed by the broker.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message