qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: QPID-2643 Building QPID with Visual Studio 2010
Date Thu, 04 Aug 2011 17:17:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1291/
-----------------------------------------------------------

(Updated 2011-08-04 17:17:32.509507)


Review request for qpid, Gordon Sim, Steve Huston, Andrew  Stitcher, and Cliff Jansen.


Changes
-------

Add qpid group to reviewers.


Summary
-------

QPID-2643 Building QPID with Visual Studio 2010
This patch changes:
 List.h - add a typedef from the original post
 IntegerTypes.h - adds 'signed' to int_8 to avoid MSVC complaint
 SessionState.cpp, qpid-perftest.cpp - adds explicit boost:: to disambiguate methods recently
defined by 'using std'.
 CMakeLists.txt - 
   Adds a CMake option that allows user to include '#define _WIN32_WINNT=0x0502' or not.
     Linux users see no change.
   This replaces CMake code that includes a similar definition when the build system _has
VS2005 installed_.
     Even if the Generator is VS2010 the def was added because VS2005 is installed. This in
not right.
   Without this definition several components define _WIN32_WINNT=0x0501 to target network
and system api components.
     Those components will still work correctly with 0x0502.
   Defining _WIN32_WINNT=0x0501 across the board causes a build error in cpp\qpid\store that
0x0502 avoids.
     This patch will move the minimum required version of Windows from WinXP to WinXP-SP3.


Diffs
-----

  /trunk/qpid/cpp/include/qpid/framing/List.h 1153911 
  /trunk/qpid/cpp/include/qpid/sys/windows/IntegerTypes.h 1153911 
  /trunk/qpid/cpp/src/CMakeLists.txt 1153911 
  /trunk/qpid/cpp/src/tests/SessionState.cpp 1153911 
  /trunk/qpid/cpp/src/tests/qpid-perftest.cpp 1153911 

Diff: https://reviews.apache.org/r/1291/diff


Testing
-------


Thanks,

Chug


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message