qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: Provides the EventNotifier type, plus example agent and unit test.
Date Tue, 23 Aug 2011 20:43:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1557/#review1601
-----------------------------------------------------------



trunk/qpid/cpp/include/qmf/EventNotifier.h
<https://reviews.apache.org/r/1557/#comment3618>

    Don't need this include use
    
    class AgentSession;



trunk/qpid/cpp/include/qmf/EventNotifier.h
<https://reviews.apache.org/r/1557/#comment3619>

    similarly use
    
    class ConsoleSession;
    
    and remove this #include



trunk/qpid/cpp/include/qmf/EventNotifier.h
<https://reviews.apache.org/r/1557/#comment3620>

    I think it would be clearer to combine this #ifdef section with the one below (the definition
here is only used there anyway



trunk/qpid/cpp/src/qmf/PosixEventNotifierImpl.cpp
<https://reviews.apache.org/r/1557/#comment3621>

    Why use a socketpair? a pipe whould do just as well for Posix.
    
    (socketpair has a certain compatibility with windows, but uses more resources if a pipe
will do)


- Andrew


On 2011-08-19 18:30:06, Darryl Pierce wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1557/
> -----------------------------------------------------------
> 
> (Updated 2011-08-19 18:30:06)
> 
> 
> Review request for qpid, Kenneth Giusti, michael goulish, and Ted Ross.
> 
> 
> Summary
> -------
> 
> Provides a new method for providing notification to an interested party when new messages
are received.
> 
> The EventNotifier class can be associated with either a console or agent session. The
object provides a file descriptor which then becomes readable when there are messages to be
processed.
> 
> This implementation only supports Posix. There is some work necessary to get a Windows
implementation in place.
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/bindings/qmf2/examples/cpp/Makefile.am 1159329 
>   trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp PRE-CREATION

>   trunk/qpid/cpp/include/qmf/AgentSession.h 1159329 
>   trunk/qpid/cpp/include/qmf/ConsoleSession.h 1159329 
>   trunk/qpid/cpp/include/qmf/EventNotifier.h PRE-CREATION 
>   trunk/qpid/cpp/src/CMakeLists.txt 1159329 
>   trunk/qpid/cpp/src/qmf.mk 1159329 
>   trunk/qpid/cpp/src/qmf/AgentSession.cpp 1159329 
>   trunk/qpid/cpp/src/qmf/AgentSessionImpl.h PRE-CREATION 
>   trunk/qpid/cpp/src/qmf/ConsoleSession.cpp 1159329 
>   trunk/qpid/cpp/src/qmf/ConsoleSessionImpl.h 1159329 
>   trunk/qpid/cpp/src/qmf/EventNotifier.cpp PRE-CREATION 
>   trunk/qpid/cpp/src/qmf/EventNotifierImpl.h PRE-CREATION 
>   trunk/qpid/cpp/src/qmf/EventNotifierImpl.cpp PRE-CREATION 
>   trunk/qpid/cpp/src/qmf/PosixEventNotifierImpl.cpp PRE-CREATION 
>   trunk/qpid/cpp/src/tests/EventNotifierTest.cpp PRE-CREATION 
>   trunk/qpid/cpp/src/tests/Makefile.am 1159329 
> 
> Diff: https://reviews.apache.org/r/1557/diff
> 
> 
> Testing
> -------
> 
> An example agent takes the existing list_agents and uses an EventNotifier to respond
to incoming messages rather than blocking on the ConsoleSession.nextReceiver() API.
> 
> A unit test verifies that the file handle provides by the EventNotifier type is properly
updating on incoming messgaes.
> 
> 
> Thanks,
> 
> Darryl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message