qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3346) Support message grouping with stricted sequence consumption across multiple consumers.
Date Tue, 16 Aug 2011 09:08:29 GMT

    [ https://issues.apache.org/jira/browse/QPID-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085597#comment-13085597
] 

jiraposter@reviews.apache.org commented on QPID-3346:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1312/#review1472
-----------------------------------------------------------



/branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp
<https://reviews.apache.org/r/1312/#comment3374>

    What's the motivation for this change?



/branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h
<https://reviews.apache.org/r/1312/#comment3375>

    Does this get used?



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h
<https://reviews.apache.org/r/1312/#comment3376>

    I don't really like making this a public method on queue. The configuration of queues
certainly needs some consolidation to make it a little more manageable. That seems to be the
primary use case here - i.e. remembering the type of queue in use.
    
    The term Disposition is also best avoided I think as in 1.0 it has a quite different meaning.



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/1312/#comment3377>

    I don't think match should be part of the MessageAllocator interface. I think the filter
perhaps should include a filter-type identifier which can be used to determine how the rest
of the map should be interpreted.
    
    We may in future want to use the same filter on different types of queue, or different
filters on the same type of queue.



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/1312/#comment3379>

    What is this used for?



/branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp
<https://reviews.apache.org/r/1312/#comment3378>

    I wonder if removeIf() would be a better choice here? Would allow removing the messages
as we iterate.
    
    Could have the count built into the predicate or could have a max-count added to the signature
(or to an doverloaded method).


- Gordon


On 2011-08-16 00:35:20, Kenneth Giusti wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1312/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-16 00:35:20)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Some initial refactoring of Queue/Consumer interface to allow for message grouping support.
 Very preliminary.
bq.  
bq.  
bq.  This addresses bug qpid-3346.
bq.      https://issues.apache.org/jira/browse/qpid-3346
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Broker.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Consumer.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/DeliveryRecord.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Fairshare.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/LegacyLVQ.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/MessageMap.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Messages.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.h 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1144324 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/Queue.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueEvents.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueueObserver.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/QueuePolicy.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/SemanticState.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/broker/ThresholdAlerts.h 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/qpid/cluster/Connection.cpp 1144319 
bq.    /branches/qpid-3346/qpid/cpp/src/tests/QueueTest.cpp 1144319 
bq.    /branches/qpid-3346/qpid/specs/management-schema.xml 1144324 
bq.    /branches/qpid-3346/qpid/tests/src/py/qpid_tests/broker_0_10/management.py 1144324

bq.  
bq.  Diff: https://reviews.apache.org/r/1312/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  minimal - passes unit tests on linux.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kenneth
bq.  
bq.



> Support message grouping with stricted sequence consumption across multiple consumers.
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3346
>                 URL: https://issues.apache.org/jira/browse/QPID-3346
>             Project: Qpid
>          Issue Type: New Feature
>          Components: C++ Broker
>    Affects Versions: 0.12
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.14
>
>         Attachments: UI.txt, msg_groups_0.2.txt
>
>
> This feature is described in the attached QIP as Policy #2: Sequenced Consumers.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message