qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Foglia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3333) Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package
Date Fri, 12 Aug 2011 14:51:27 GMT

    [ https://issues.apache.org/jira/browse/QPID-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084161#comment-13084161
] 

Anthony Foglia commented on QPID-3333:
--------------------------------------

I don't know how we got the NotAttachedException.  One of the other coders on my team discovered
it.  I have the chat logs, and but they're not very helpful.

  Me: No.  Any idea what's different?  You're running on what machine?
 Him: it happened to two machines at once
 Him: oh, maybe a queue overflowed and it's just a different error message than I'm used to
from the qpid messaging library
[...]
 Him: maybe it's idsconnecting  from the broker when it sees the queue is full?
 Him: because sessionDisconnected is a pretty different sounding exception from ueueOverFlow
or whatever it is we're currently catching

This was a month ago, and we were performing some stress tests on our code.  And our code
isn't currently catching Detached anymore, so there's no help there.

I'd suggest leaving the patch in.  If you/we ever figure out what threw it, and properly translate
it, we can add a patch to also convert that.  There's no reason you can't have multiple C++
exception types translate to the same Python type.  It's not ideal, but it's possible.

The only concern would be if the NotAttachedException shouldn't be translated to a Detached
in a signficant number of cases.

Another option is to include the qpid::framing header in python.i, not qpid.i, but I figured
other bindings should eventually do the same translations.  It does give you one less place
to change code, should you ever catch and translate the exception in the qpid::messaging space.

I vote for putting it in.

If I have time, I'll work on breaking that patch up so the Detached exception stuff is separate
from the other three.  (Ironically, I think it was multiple changes originally, that I rebased
into one for your convenience. :-) )

> Make Python SWIG bindings a drop-in replacement for pure Python qpid.messaging package
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3333
>                 URL: https://issues.apache.org/jira/browse/QPID-3333
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Client
>    Affects Versions: 0.11, Future
>            Reporter: Anthony Foglia
>            Assignee: Gordon Sim
>         Attachments: 0001-Wrap-NoMessageAvailable-as-Empty-exception.patch, 0002-Change-Connection-interface-to-match-pure-python.patch,
0003-Change-Session-interface-to-match-pure-python.patch, 0004-Change-Receiver-interface-to-match-pure-python.patch,
0005-Change-Sender-interface-to-match-pure-python.patch, 0006-Change-Message-interface-to-match-pure-python.patch,
0007-Handle-connection-options.patch, 0008-Fixes-and-more-improvements-to-Message-objects.patch,
0009-Wrapping-of-more-exceptions.patch, 0010-Add-session-property-to-senders-and-receivers.patch
>
>
> These patches are make the compile Python SWIG bindings to the C++ client much closer
to a drop-in replacement for the Python qpid.messaging package.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message