qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3373) Java client: connectionFactory.createConnection method should not rewrite stored credentials
Date Thu, 01 Sep 2011 14:17:10 GMT

    [ https://issues.apache.org/jira/browse/QPID-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095307#comment-13095307
] 

Alex Rudyy commented on QPID-3373:
----------------------------------

Rajith,

when test from ConnectionFactoryTest is run as part of any existing test profile it fails
because broker port is not 5672.

I would suggest to add the following change into ConnectionFactoryTest
{code}
diff --git a/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ConnectionFactoryTest.java
b/qpid/java/systests/src/main/java/org/a
index 0b9ef8c..d128c5d 100644
--- a/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ConnectionFactoryTest.java
+++ b/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ConnectionFactoryTest.java
@@ -13,7 +13,8 @@ public class ConnectionFactoryTest extends QpidBrokerTestCase
      */
     public void testCreateConnectionWithUsernamePassword() throws Exception
     {
-        String URL = "amqp://guest:guest@clientID/test?brokerlist='tcp://localhost:5672'";
+        String brokerUrl = getBroker().toString();
+        String URL = "amqp://guest:guest@clientID/test?brokerlist='" + brokerUrl + "'";
         AMQConnectionFactory factory = new AMQConnectionFactory(URL);
         
         AMQConnection con = (AMQConnection)factory.createConnection();

{code}
With this change the test will pass on existing java profiles


Alternatively, it can be excluded from all java test profiles.

What do you think about it?

> Java client: connectionFactory.createConnection method should not rewrite stored credentials
> --------------------------------------------------------------------------------------------
>
>                 Key: QPID-3373
>                 URL: https://issues.apache.org/jira/browse/QPID-3373
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.10
>            Reporter: Pavel Moravec
>            Assignee: Rajith Attapattu
>            Priority: Minor
>             Fix For: 0.14
>
>         Attachments: authNoCredentialsInSecondConnection.java.gz, qpid-java-0.10.connection_credentials.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Method connectionFactory.createConnection("foo", "bar") causes than Java client caches
the credentials and overwrites default ones provided in connection URL. Thus subsequent calling
of connectionFactory.createConnection() method (without a parameter) results in using the
credentials "foo" / "bar" despite default ones should be used.
> How reproducible:
> 100%
> Steps to Reproduce:
> 1. Setup a broker with PLAIN authentication
> 2. Compile attached JUnit test 
> 3. Run it (java org.junit.runner.JUnitCore authNoCredentialsInSecondConnection)
> Actual results:
> In try .. catch block, connectionFactory2.createConnection(); does not raise an exception
that authentication failed. (and thus fail command below raises java.lang.AssertionError exception).
In fact, connectionFactory2.createConnection(); uses "guest" / "guest" credentials set for
connectionFactory1.
> Expected results:
> Authentication fails for connectionFactory2.createConnection(); as it uses default credentials
from URL (what is "dummy" / "dummy").

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message