qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew MacBean (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3428) Verifification of unique client ID does not work in Java Broker
Date Thu, 01 Sep 2011 10:10:10 GMT

    [ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095213#comment-13095213
] 

Andrew MacBean commented on QPID-3428:
--------------------------------------

Based on test case and implementation in Java client and C++ broker for (QPID-3269) the broker
has been changed to validate that the client id used is unique when creating a new session
and attaching.

If the client id is null or is unique then the session is attached as before, otherwise it
invokes session detached and sets the session detach code to SESSION_BUSY and calls session.closed().

A patch has been attached for review.  The patch also includes some minor client changes to
fix a small bug found during development in the Session.awaitOpen() method which was throwing
a SessionException even if the state was OPEN as expected. This was "swallowed" later so had
no real knock on effect anyway.

> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
>                 Key: QPID-3428
>                 URL: https://issues.apache.org/jira/browse/QPID-3428
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>            Priority: Minor
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should
not allow creation of connections with the same client id. However, this functionality does
not work at the moment.
> JUnit test  org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification
fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating
the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message