qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-3459) Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
Date Wed, 07 Sep 2011 20:55:10 GMT

     [ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robbie Gemmell updated QPID-3459:
---------------------------------

    Assignee: Alex Rudyy  (was: Robbie Gemmell)
      Status: Open  (was: Ready To Review)

I dont think the changes in the patch will resolve the underlying test failure. 

>From the test we know that the 5th message has been recieved, and yet the statistcs counter
still reports 4, meaning it has not yet been incremented. Synchronizing just those methods
should have no effect in that scenario, as the value is retrieved via JMX and so involvs another
roundtrip to the broker after the message has been received at the client. Given this, and
that the occurences of this failure have only been seen on an old dual core machine, I think
its likely that thread scheduling is occurring such that the delivering thread has yielded
before incrementing the counter, meaning this synchronization wont help. 

Adding additional synchronization on the statistics object around the message delivery and
increment would also be required I believe, which isnt going to be nice for performance (and
furthermore, the statistics are optional and off by default).An alternative might be to increment
the counter immediatley prior to the delivery attempt, although this wasn't done previously
since any exceptions thrown during delivery would make the value invalid, and reverting the
increment if an exception occurs is not as simple as it sounds since it means manipulating
the statistics which may have already moved on to a new reporting interval. Ick to all of
the above.

> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails
on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3459
>                 URL: https://issues.apache.org/jira/browse/QPID-3459
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>            Priority: Minor
>         Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message