qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3428) Verification of unique client ID does not work with Java Broker
Date Mon, 12 Sep 2011 11:07:08 GMT

    [ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102543#comment-13102543
] 

Robbie Gemmell commented on QPID-3428:
--------------------------------------

Looks good, but I missed something in my original review that still needs addressed. The 0-10
session naming should be per-principal, so currently the verification being done is too strict
in that it checks only if the name exists, not whether it is for the same principal, so we
need to relax that accordingly.

> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
>                 Key: QPID-3428
>                 URL: https://issues.apache.org/jira/browse/QPID-3428
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.13
>
>         Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch,
[QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should
not allow creation of connections with the same client id. However, this functionality does
not work at the moment.
> JUnit test  org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification
fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating
the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message