qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chuck Rolke (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-2905) Fixes for mingw cross-compilation (C++)
Date Tue, 04 Oct 2011 20:19:34 GMT

    [ https://issues.apache.org/jira/browse/QPID-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120436#comment-13120436
] 

Chuck Rolke commented on QPID-2905:
-----------------------------------

I believe that checkin r1104662 has an error that breaks Solaris builds.
File qpid/cpp/src/qpid/sys/alloca.h has unreachable code at line 38.

To repair this I propose moving lines
#  if !defined _WINDOWS && !defined WIN32
#    include <alloca.h>
#  endif
#endif

outside of the conditional block in which they are now contained.
                
> Fixes for mingw cross-compilation (C++)
> ---------------------------------------
>
>                 Key: QPID-2905
>                 URL: https://issues.apache.org/jira/browse/QPID-2905
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, C++ Client, Code Generator
>    Affects Versions: 0.7
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>             Fix For: 0.11
>
>         Attachments: cross2.diff
>
>
> In attempting to cross-compile the Qpid trunk in the MinGW environment, a number of build
errors were seen.  Attached to this issue is a patch that fixes the errors and builds cleanly
on Linux/gcc and MS Visual Studio as well.
> The classes of error discovered are:
> 1) Case-sensitivity of file names (i.e. Secure32.lib => secure32.lib)
> 2) Syntax issues where MSVC is too lenient (semicolon after the closing brace of a template
function)
> 3) *_EXTERN on DLL APIs.  MinGW doesn't like externs on in-line functions, requires externs
on class names.
> 4) const_case<char*>() needed on LPTSTR arguments in the Windows API
> 5) Unused function arguments need to be commented out
> 6) the *_s variants of ::localtime, ::strncpy, ::strerror can't be used
> Before I commit, I would appreciate some review and feedback on this patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message