qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Goldstein (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-3578) qpid-queue-stats doesn't support multiple filters (despite --help saying it does)
Date Wed, 02 Nov 2011 19:53:32 GMT

     [ https://issues.apache.org/jira/browse/QPID-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andy Goldstein updated QPID-3578:
---------------------------------

    Description: 
Trying to use multiple filters with qpid-queue-stats does not work due to an indentation issue
in the Python code.  For example:

{{qpid-queue-stats -f "a.*,b.*"}}

will only find queues matching the a.* pattern.

The issue is that if the first pattern fails, instead of trying all additional patterns, execution
stops.  This is because the check to see if all matches failed is indented one level too far
to the right.  As a result, this check executes inside the for loop, instead of outside. 
The diff below fixes the issue:

{{diff --git a/qpid/tools/src/py/qpid-queue-stats b/qpid/tools/src/py/qpid-queue-stats
index 54f22df..562ccce 100755
--- a/qpid/tools/src/py/qpid-queue-stats
+++ b/qpid/tools/src/py/qpid-queue-stats
@@ -84,8 +84,8 @@ class BrokerManager(Console):
         if x.match(name):                 
           match = True
           break
-        if match == False:
-          return
+      if match == False:
+        return
 
     if last == None:
       lastSample = first}}

  was:
Trying to use multiple filters with qpid-queue-stats does not work due to an indentation issue
in the Python code.  For example:

qpid-queue-stats -f "a.*,b.*" will only find queues matching the a.* pattern.

The issue is that if the first pattern fails, instead of trying all additional patterns, execution
stops.  This is because the check to see if all matches failed is indented one level too far
to the right.  As a result, this check executes inside the for loop, instead of outside. 
The diff below fixes the issue:

diff --git a/qpid/tools/src/py/qpid-queue-stats b/qpid/tools/src/py/qpid-queue-stats
index 54f22df..562ccce 100755
--- a/qpid/tools/src/py/qpid-queue-stats
+++ b/qpid/tools/src/py/qpid-queue-stats
@@ -84,8 +84,8 @@ class BrokerManager(Console):
         if x.match(name):                 
           match = True
           break
-        if match == False:
-          return
+      if match == False:
+        return
 
     if last == None:
       lastSample = first

    
> qpid-queue-stats doesn't support multiple filters (despite --help saying it does)
> ---------------------------------------------------------------------------------
>
>                 Key: QPID-3578
>                 URL: https://issues.apache.org/jira/browse/QPID-3578
>             Project: Qpid
>          Issue Type: Bug
>          Components: python tools
>            Reporter: Andy Goldstein
>            Priority: Minor
>         Attachments: qpid-3578.diff
>
>
> Trying to use multiple filters with qpid-queue-stats does not work due to an indentation
issue in the Python code.  For example:
> {{qpid-queue-stats -f "a.*,b.*"}}
> will only find queues matching the a.* pattern.
> The issue is that if the first pattern fails, instead of trying all additional patterns,
execution stops.  This is because the check to see if all matches failed is indented one level
too far to the right.  As a result, this check executes inside the for loop, instead of outside.
 The diff below fixes the issue:
> {{diff --git a/qpid/tools/src/py/qpid-queue-stats b/qpid/tools/src/py/qpid-queue-stats
> index 54f22df..562ccce 100755
> --- a/qpid/tools/src/py/qpid-queue-stats
> +++ b/qpid/tools/src/py/qpid-queue-stats
> @@ -84,8 +84,8 @@ class BrokerManager(Console):
>          if x.match(name):                 
>            match = True
>            break
> -        if match == False:
> -          return
> +      if match == False:
> +        return
>  
>      if last == None:
>        lastSample = first}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message