qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3566) ConnectionCloseTest fails with spurious thread creation
Date Tue, 01 Nov 2011 10:32:32 GMT

    [ https://issues.apache.org/jira/browse/QPID-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141068#comment-13141068
] 

Keith Wall commented on QPID-3566:
----------------------------------

I can see from the test output that the test profile was the default java-mms.0-10 and as
such Java Broker and Java client are co-located in the same VM.

The heuristic used by the test to calculate the number of additional threads that may remain
after the test is broken.   It is relying on QpidBrokerTestCase#isExternalBroker which is
currently always returning true even when broker and client are co-located within the same
VM.  As a result, the threshold applied is half that that the author intended.

This test normally does not fail, so I suspect that you were victim of unlucky timing.  I
notice that the Virtual Host's housekeeping thread happened to be in progress when the test
made the measurement.

I think we need to:

1) Fix QpidBrokerTestCase#isExternalBroker and the tests that use it.
2) Consider whether this is still a valuable test as the threading model used by the application
is very different since the removal of Mina.

I think neither of these changes are sufficiently important to make 0-14 and should await
trunk reopening.  I've downgraded this Jira to Minor.
 
                
> ConnectionCloseTest fails with spurious thread creation
> -------------------------------------------------------
>
>                 Key: QPID-3566
>                 URL: https://issues.apache.org/jira/browse/QPID-3566
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.13
>         Environment: Fedora 15 x86_64
> java version "1.6.0_22"
> OpenJDK Runtime Environment (IcedTea6 1.10.4) (fedora-60.1.10.4.fc15-x86_64)
> OpenJDK 64-Bit Server VM (build 20.0-b11, mixed mode)
>            Reporter: Justin Ross
>            Assignee: Keith Wall
>         Attachments: TEST-org.apache.qpid.test.unit.client.connection.ConnectionCloseTest.testSendReceiveClose.out
>
>
> Testsuite: org.apache.qpid.test.unit.client.connection.ConnectionCloseTest
> Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 31.176 sec
> Testcase: testSendReceiveClose took 31.009 sec
>         FAILED
> Spurious thread creation exceeded threshold, 10 threads created.
> junit.framework.AssertionFailedError: Spurious thread creation exceeded threshold, 10
threads created.
>         at org.apache.qpid.test.unit.client.connection.ConnectionCloseTest.testSendReceiveClose(ConnectionCloseTest.java:97)
>         at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:240)
>         at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:135)
> Testcase: testConnectionCloseOnOnForcibleBrokerStop took 0.164 sec

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message