qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "rajith attapattu" <rajit...@gmail.com>
Subject Review Request: Add at least basic functionality to add ACL rules dynamically
Date Wed, 07 Dec 2011 01:52:53 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for qpid, Alan Conway, Gordon Sim, and Kim van der Riet.


The following patch allows an ACL rule to be added to the AclData object held in memory. Updates
are not propagated in a clustered setup. Therefore qmf folks are discouraged from using this
method until a proper solution to the clustered setup is worked out. This was done to facilitate
Alan Conway's work on QPID-3665

Alan was kind enough to do initial review and testing.

P.S I promise to remove all trailing whitespaces before commit. I already updated the patch
after removing whitespaces in Acl.cpp, but doing so for other files like AclData.cpp produces
a much larger diff and distracts from the changes that I want to be reviewed. 

This addresses bug QPID-3665.


  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/acl/Acl.h 1209722 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1209722 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/acl/AclData.h 1209722 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1209722 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/broker/AclModule.h 1209722

Diff: https://reviews.apache.org/r/3041/diff


I believe Alan already has a test case as part of QPID-3665.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message