qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: QPID-3193 .NET Binding - handling disposed objects
Date Sun, 18 Dec 2011 05:31:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3239/#review3966
-----------------------------------------------------------



trunk/qpid/cpp/bindings/qpid/dotnet/src/BindingCommon.h
<https://reviews.apache.org/r/3239/#comment8974>

    I think locking inside this macro introduces hidden beviour that needs to be explicit.
    
    Particularly as the lock scope will last (much) longer than the macro.
    
    So I'd suggest just doing the lock explicitly in the line before the macro.
    
    At the _very least_ rename the macro to something that indicates it locks this.
    LOCK_THIS_AND_THROW_IF_DISPOSED comes to mind


- Andrew


On 2011-12-16 21:04:58, Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3239/
> -----------------------------------------------------------
> 
> (Updated 2011-12-16 21:04:58)
> 
> 
> Review request for qpid, Andrew Stitcher, Gordon Sim, Ted Ross, Steve Huston, and Cliff
Jansen.
> 
> 
> Summary
> -------
> 
> QPID-3193 .NET Binding - proper handling of disposed objects.
> 
> 
> This addresses bug QPID-3193.
>     https://issues.apache.org/jira/browse/QPID-3193
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/bindings/qpid/dotnet/src/BindingCommon.h PRE-CREATION 
>   trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.h 1215245 
>   trunk/qpid/cpp/bindings/qpid/dotnet/src/Message.cpp 1215245 
>   trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc10/org.apache.qpid.messaging.vcxproj 1215245

>   trunk/qpid/cpp/bindings/qpid/dotnet/src/msvc9/org.apache.qpid.messaging.vcproj 1215245

> 
> Diff: https://reviews.apache.org/r/3239/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chug
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message