qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Review Request: QPID-3603: HA backup rejects client connections.
Date Fri, 20 Jan 2012 17:47:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3570/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Kenneth Giusti.


Summary
-------


This commit introduces a ConnectionObserver, needed by the HA code to get notified of connections
opening.
I also took the LinkRegistry::notify* calls out of Connection and refactored LinkRegistry
to use a ConnectionObserver.

Do the ConnectionObserver changes this look good to put on trunk?


Diffs
-----

  /branches/qpid-3603-2/qpid/cpp/src/Makefile.am 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/ha.mk 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/Broker.h 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/Connection.cpp 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/ConnectionObserver.h PRE-CREATION 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/ConnectionObservers.h PRE-CREATION 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/ConnectionExcluder.h PRE-CREATION 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaBroker.h 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaBroker.cpp 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/HaPlugin.cpp 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/qpid/ha/Settings.h 1233690 
  /branches/qpid-3603-2/qpid/cpp/src/tests/ha_tests.py 1233690 

Diff: https://reviews.apache.org/r/3570/diff


Testing
-------


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message