qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request: QPID-3603: Set connection.start client-properties argument from python.
Date Mon, 23 Jan 2012 21:27:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3595/#review4540
-----------------------------------------------------------



/trunk/qpid/python/qpid/delegates.py
<https://reviews.apache.org/r/3595/#comment10134>

    This line looks suspicious. Should that actually be kwargs.get("client_properties",{})?


- Rafael


On 2012-01-23 20:01:03, Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3595/
> -----------------------------------------------------------
> 
> (Updated 2012-01-23 20:01:03)
> 
> 
> Review request for qpid.
> 
> 
> Summary
> -------
> 
> The client-properties can be specified for old-API, new-API and QMF connections.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/extras/qmf/src/py/qmf/console.py 1234410 
>   /trunk/qpid/python/qpid/delegates.py 1234410 
>   /trunk/qpid/python/qpid/messaging/driver.py 1234410 
>   /trunk/qpid/python/qpid/messaging/endpoints.py 1234410 
> 
> Diff: https://reviews.apache.org/r/3595/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message