qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3803) System tests SortedQueueTest#test<ACK MODE>SortedQueue fail ocasionally on slow machines
Date Fri, 03 Feb 2012 10:53:53 GMT

    [ https://issues.apache.org/jira/browse/QPID-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199637#comment-13199637
] 

Robbie Gemmell commented on QPID-3803:
--------------------------------------

Looking at the changes I would say the increase from 5 to 50 seconds would be better wrapped
in an 'if persistent else' so that the extra time is only allotted on persistent runs (which
is where the problem occurred due to slow disks), as I think taking over 5 ssecodns for 200
transient messages is something we would want to know about.

In the changes to the while loop, it now appears like the loop can spin while failing to receive
messages in the 1 second timeout. I would probably choose to remove that possibility and just
allow more time for an individual receive to succeed (again probably selectively allocating
a longer time on persistent runs e.g 3 seconds, as it would be interesting to know that it
took longer than a second on a transient run). 
                
> System tests SortedQueueTest#test<ACK MODE>SortedQueue fail ocasionally on slow
machines
> ----------------------------------------------------------------------------------------
>
>                 Key: QPID-3803
>                 URL: https://issues.apache.org/jira/browse/QPID-3803
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: 0.15
>            Reporter: Alex Rudyy
>            Assignee: Robbie Gemmell
>             Fix For: 0.15
>
>         Attachments: 0001-QPID-3803-Fix-test-SortedQueueTest-failures.patch, TEST-org.apache.qpid.server.queue.SortedQueueTest.testClientAckSortedQueue.out,
TEST-org.apache.qpid.server.queue.SortedQueueTest.txt
>
>
> Testcase: testClientAckSortedQueue took 9.829 sec
>         FAILED
> Incorrect number of messages received expected:<200> but was:<42>
> junit.framework.AssertionFailedError: Incorrect number of messages received expected:<200>
but was:<42>
>         at org.apache.qpid.server.queue.SortedQueueTest.runThroughSortedQueueForSessionMode(SortedQueueTest.java:154)
>         at org.apache.qpid.server.queue.SortedQueueTest.testClientAckSortedQueue(SortedQueueTest.java:122)
>         at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
>         at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message