qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Ross <tr...@redhat.com>
Subject Re: svn commit: r1291436 - in /qpid/trunk/qpid/cpp: include/qpid/framing/ include/qpid/types/ managementgen/qmfgen/ managementgen/qmfgen/templates/ src/qmf/ src/qpid/broker/ src/qpid/ha/
Date Mon, 20 Feb 2012 21:23:19 GMT
The scope of this fix seems to be much greater than that of the commit 
that broke Windows.

A couple of questions:

1) Why add "BrokerImportExport.h" to cpp/src/qmf?  There's already a 
cpp/include/qmf/ImportExport.h that serves the same purpose.
2) Why all the changes to the generated code?  The old generation 
templates worked fine under Windows.

The main thing you need to be concerned with is that any classes and 
class methods that need to be accessible from outside the 
DLL/shared-object are prefixed with the proper EXTERN symbol *for the 
library*.  Furthermore, there's a different EXTERN symbol for inline 
methods.

-Ted


On 02/20/2012 03:45 PM, aconway@apache.org wrote:
> Author: aconway
> Date: Mon Feb 20 20:45:22 2012
> New Revision: 1291436
>
> URL: http://svn.apache.org/viewvc?rev=1291436&view=rev
> Log:
> NO-JIRA: Fix missing EXTERN declarations, broke windows build.
>
> Added:
>      qpid/trunk/qpid/cpp/src/qmf/BrokerImportExport.h   (with props)
> Modified:
>      qpid/trunk/qpid/cpp/include/qpid/framing/SequenceNumber.h
>      qpid/trunk/qpid/cpp/include/qpid/framing/SequenceSet.h
>      qpid/trunk/qpid/cpp/include/qpid/types/Variant.h
>      qpid/trunk/qpid/cpp/managementgen/qmfgen/schema.py
>      qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h
>      qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Event.h
>      qpid/trunk/qpid/cpp/managementgen/qmfgen/templates/Package.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/Broker.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/Link.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp
>      qpid/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/Queue.h
>      qpid/trunk/qpid/cpp/src/qpid/broker/SemanticState.h
>      qpid/trunk/qpid/cpp/src/qpid/ha/ReplicatingSubscription.h
>
> [SNIP...]
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:commits-subscribe@qpid.apache.org
>


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message