qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3867) AMQQueueMBean#clearQueue|moveMessages|copyMessages should be certain to rollback transactions in the event of exception
Date Sun, 26 Feb 2012 23:32:48 GMT

    [ https://issues.apache.org/jira/browse/QPID-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216959#comment-13216959
] 

Robbie Gemmell commented on QPID-3867:
--------------------------------------

My only reservation is around the queue depth checking in the tests, I think its possible
that will sporadically fail on certain slower CI instances due to the commit response going
back before the in-memory enqueue is completed.

Im not too fussed about the queue parameter. The problem with doing that would be that the
MBean would then need to be the one doing the lookup so that it could provide the AMQQueue
object, which isnt really any nicer since it would be good if the management layer was as
dumb-as-a-brick where possible and AMQQueueMBean is already an example of where its not.
                
> AMQQueueMBean#clearQueue|moveMessages|copyMessages should be certain to rollback transactions
in the event of exception
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3867
>                 URL: https://issues.apache.org/jira/browse/QPID-3867
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>            Priority: Critical
>
> AMQQueueMBean#clearQueue|moveMessages|copyMessages all leave open that possibility that
a LocalTransaction goes uncommitted (or unrolledback) in the event of exception.
> This will lead to uncontrolled store growth when used with BDB as would block the action
of the cleaner thread.
> A finally block should be used to ensure that transaction is rolled back on any exception.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


Mime
View raw message