qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3896: Generate unique names for queue auto delete timer to allow cluster to correctly track the timers.
Date Tue, 20 Mar 2012 14:08:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4413/#review6117
-----------------------------------------------------------

Ship it!


- Alan


On 2012-03-20 14:06:07, Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4413/
> -----------------------------------------------------------
> 
> (Updated 2012-03-20 14:06:07)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Summary
> -------
> 
> When an auto-delete queue is created, a timer is used to detect when the queue should
be deleted.  Since the timer is managed by the queue, the name of the timer is unimportant,
and the queue code uses the same name for all timers.
> 
> This creates a problem for the clustering code, which must monitor each timer.  This
patch changes the queue code to create a timer with a name based on the name of the queue.
 This allows the cluster code to correctly distinguish these timers. 
> 
> 
> This addresses bug qpid-3896.
>     https://issues.apache.org/jira/browse/qpid-3896
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1302629 
>   /trunk/qpid/cpp/src/qpid/cluster/ClusterTimer.cpp 1302629 
> 
> Diff: https://reviews.apache.org/r/4413/diff
> 
> 
> Testing
> -------
> 
> unit
> 
> 
> Thanks,
> 
> Kenneth
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message