qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: Add management hooks into ACL lookup engine for C++ broker
Date Tue, 27 Mar 2012 22:33:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/#review6454
-----------------------------------------------------------



trunk/qpid/cpp/src/qpid/acl/Acl.cpp
<https://reviews.apache.org/r/4525/#comment14084>

    never use "catch (...)" unless you also use "throw"
    - it thoroughly screws up debugging on windows.
    - If you don't know at least roughly what you are expecting you shouldn't be catching
it the most general you should catch is std::exception&.
    
    [I also agree with Alan's assessment about the try blocks being way too granular]


- Andrew


On 2012-03-27 19:10:23, Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4525/
> -----------------------------------------------------------
> 
> (Updated 2012-03-27 19:10:23)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
> 
> 
> Summary
> -------
> 
> Add management methods that let a customer drive arbitrary ACL lookup queries. 
> 
> 
> This addresses bug QPID-3918.
>     https://issues.apache.org/jira/browse/QPID-3918
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/Modules.cpp 1305877 
>   trunk/qpid/cpp/src/qpid/acl/Acl.h 1305877 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1305877 
>   trunk/qpid/cpp/src/qpid/acl/AclData.cpp 1305877 
>   trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1305877 
> 
> Diff: https://reviews.apache.org/r/4525/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chug
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message