qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-3921) C++ header files need tidyup (in several different ways)
Date Wed, 28 Mar 2012 21:11:27 GMT

     [ https://issues.apache.org/jira/browse/QPID-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Stitcher updated QPID-3921:
----------------------------------

    Description: 
There are a number of problems with the header files and their use in the qpid code base:
1. There are many header files with non standard header guards -
- either using incorrect definitions (some starting with double underscore, some with the
header guards in the wrong place in the header file.

2. There are many header files that are included unnecessarily, making the compile times longer.
- This is especially true when a header file is included in another header file instead of
an implementation file.
- There are (many?) cases where types could be forward declared instead of using the header
file that defines them.

  was:
There are a number of problems with the header files and their use in the qpid code base:
1. There are many header files with non standard header guards -
- either using incorrect definitiona (some starting with double underscore, some with the
header guards in the wrong place in the header file.
2. There are many header files that are included unnecessarily, making the compile times longer.
- This is especially true when a header file is included in another header file instead of
an implementation file.
- There are (many?) cases where types could be forward declared instead of using the header
file that defines them.

    
> C++ header files need tidyup (in several different ways)
> --------------------------------------------------------
>
>                 Key: QPID-3921
>                 URL: https://issues.apache.org/jira/browse/QPID-3921
>             Project: Qpid
>          Issue Type: Improvement
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> There are a number of problems with the header files and their use in the qpid code base:
> 1. There are many header files with non standard header guards -
> - either using incorrect definitions (some starting with double underscore, some with
the header guards in the wrong place in the header file.
> 2. There are many header files that are included unnecessarily, making the compile times
longer.
> - This is especially true when a header file is included in another header file instead
of an implementation file.
> - There are (many?) cases where types could be forward declared instead of using the
header file that defines them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message