qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3918) Add management acl-query test methods to C++ broker ACL plugin
Date Wed, 04 Apr 2012 18:02:18 GMT

    [ https://issues.apache.org/jira/browse/QPID-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246522#comment-13246522
] 

jiraposter@reviews.apache.org commented on QPID-3918:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/#review6690
-----------------------------------------------------------

Ship it!


Except for the whitespace, this looks good.


trunk/qpid/cpp/src/tests/acl.py
<https://reviews.apache.org/r/4525/#comment14493>

    Looks like a bunch of whitespace errors here.


- Andrew


On 2012-04-04 15:42:02, Chug Rolke wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4525/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-04 15:42:02)
bq.  
bq.  
bq.  Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add management methods that let a customer drive arbitrary ACL lookup queries. 
bq.  
bq.  
bq.  This addresses bug QPID-3918.
bq.      https://issues.apache.org/jira/browse/QPID-3918
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/qpid/cpp/src/qpid/acl/Acl.h 1307073 
bq.    trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1307073 
bq.    trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1307073 
bq.    trunk/qpid/cpp/src/qpid/broker/AclModule.h 1307073 
bq.    trunk/qpid/cpp/src/tests/acl.py 1307073 
bq.    trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1307073 
bq.  
bq.  Diff: https://reviews.apache.org/r/4525/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Chug
bq.  
bq.


                
> Add management acl-query test methods to C++ broker ACL plugin
> --------------------------------------------------------------
>
>                 Key: QPID-3918
>                 URL: https://issues.apache.org/jira/browse/QPID-3918
>             Project: Qpid
>          Issue Type: New Feature
>          Components: C++ Broker
>    Affects Versions: 0.14
>            Reporter: Chuck Rolke
>            Assignee: Chuck Rolke
>         Attachments: acl-test-01-brokerlog.txt, acl-test-01-rules.acl, acl-test-01.log,
acl-test-01.py
>
>
> In its current form the ACL module is not testable in a customer deployment. The ACL
module loads the ACL file and from then on only real-world activity triggers allow and deny
decisions. 
> This feature proposal adds two management methods that are directly tied to the ACL decision
Lookup functions. Using them a customer may start a dummy broker process that uses his actual
(1) ACL rule file. Then using a management application the customer may fire off a set of
lookups against his rule file to see if the ACL rules deliver the intended results.
> This feature could also be used to augment the self tests. It is very hard to stage enough
driver code to trigger some of the ACL queries. Using the proposed methods then the self test
can launch any ACL query directly.
> (1) As usual the ACL file must be bent enough to allow 'anonymous' to have access to
the management methods

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message