qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: Add management hooks into ACL lookup engine for C++ broker
Date Wed, 04 Apr 2012 15:42:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/
-----------------------------------------------------------

(Updated 2012-04-04 15:42:02.279036)


Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.


Changes
-------

Use the management hooks in the acl.py self test.
There are two parts to the ACL tests: 1) When something happens in the broker does the correct
authorise() function get called? and 2) When an authorise() function gets called does the
ACL logic evaluate correctly? This patch addresses part 2 making it clear and easy to test
the ACL logic.


Summary
-------

Add management methods that let a customer drive arbitrary ACL lookup queries. 


This addresses bug QPID-3918.
    https://issues.apache.org/jira/browse/QPID-3918


Diffs (updated)
-----

  trunk/qpid/cpp/src/qpid/acl/Acl.h 1307073 
  trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1307073 
  trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1307073 
  trunk/qpid/cpp/src/qpid/broker/AclModule.h 1307073 
  trunk/qpid/cpp/src/tests/acl.py 1307073 
  trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1307073 

Diff: https://reviews.apache.org/r/4525/diff


Testing
-------


Thanks,

Chug


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message