qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: Add management hooks into ACL lookup engine for C++ broker
Date Wed, 04 Apr 2012 18:00:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4525/#review6690
-----------------------------------------------------------

Ship it!


Except for the whitespace, this looks good.


trunk/qpid/cpp/src/tests/acl.py
<https://reviews.apache.org/r/4525/#comment14493>

    Looks like a bunch of whitespace errors here.


- Andrew


On 2012-04-04 15:42:02, Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4525/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 15:42:02)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and rajith attapattu.
> 
> 
> Summary
> -------
> 
> Add management methods that let a customer drive arbitrary ACL lookup queries. 
> 
> 
> This addresses bug QPID-3918.
>     https://issues.apache.org/jira/browse/QPID-3918
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/acl/Acl.h 1307073 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1307073 
>   trunk/qpid/cpp/src/qpid/acl/management-schema.xml 1307073 
>   trunk/qpid/cpp/src/qpid/broker/AclModule.h 1307073 
>   trunk/qpid/cpp/src/tests/acl.py 1307073 
>   trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1307073 
> 
> Diff: https://reviews.apache.org/r/4525/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chug
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message