qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Conway <acon...@redhat.com>
Subject Re: Review Request: QPID-3767: identify Link and Bridge objects by an assigned name, rather than by the remote Host and Port.
Date Wed, 11 Apr 2012 13:15:21 GMT
On 04/11/2012 09:06 AM, Kenneth Giusti wrote:
>
>
>> On 2012-04-10 14:26:01, Alan Conway wrote:
>>> /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp, line 57
>>> <https://reviews.apache.org/r/4659/diff/1/?file=100190#file100190line57>
>>>
>>>      replicatorName(q->getName()) is already unique within the broker (actually
its an exchange name) so the UUID is not necessary.
>
> Hi Alan - thanks for the review.  I'm cleaning up these nits, however:
>
> If I change the setting of the bridgeName to remove the addition of the uuid, and do
this instead:
>      bridgeName = replicatorName(q->getName());
> then the following ha tests start failing:
>
> ha_tests.ShortTests.test_backup_failover:
>         AssertionError: Lists differ: ['a'] != []
> ha_tests.ShortTests.test_queue_replica_failover:
>        AssertionError: Lists differ: ['a'] != []
> ha_tests.ShortTests.test_send_receive:
>       AssertionError: Lists differ: [991L, 992L, 993L, 994L, 995L,... != []
> ha_tests.ShortTests.test_sync:
>      AssertionError: Lists differ: ['0', '1', '2', '3', '4', '5',... != []
>
> I'll re-try this change after I merge the branch to your latest changes on trunk.


Just leave in the UUID, I must be overlooking something...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message