qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3963: have the Link monitor the remote broker's amq.failover exchange, and use this information during failover.
Date Tue, 01 May 2012 13:11:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4846/#review7420
-----------------------------------------------------------

Ship it!


- Alan


On 2012-04-26 19:19:31, Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4846/
> -----------------------------------------------------------
> 
> (Updated 2012-04-26 19:19:31)
> 
> 
> Review request for qpid, Alan Conway and Gordon Sim.
> 
> 
> Summary
> -------
> 
> Still a WIP, but I wanted early feedback as I'm not too experienced with the subscription
management code involved (completely stolen from Alan).
> 
> This patch allows the Link to subscribe to the remote broker's amq.failover exchange
- if it exists.  This allows the Link to be updated dynamically should the remote broker be
part of a cluster, and the cluster membership changes.
> 
> Light testing against a cluster confirms that this patch fixes qpid-3963.  Testing against
a non-cluster remote causes the remote to log the following error, but otherwise behaves ok:
> 
> 2012-04-23 16:45:27 error Execution exception: not-found: Exchange not found: amq.failover
(../../../qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp:101)
> 
> 
> This addresses bug qpid-3963.
>     https://issues.apache.org/jira/browse/qpid-3963
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/xml/cluster.xml 1329301 
>   /trunk/qpid/cpp/src/qpid/cluster/Connection.h 1329301 
>   /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1329301 
>   /trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp 1329301 
>   /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1329301 
>   /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1329301 
>   /trunk/qpid/cpp/src/qpid/broker/ExchangeRegistry.cpp 1329301 
>   /trunk/qpid/cpp/src/qpid/broker/Link.h 1329301 
> 
> Diff: https://reviews.apache.org/r/4846/diff
> 
> 
> Testing
> -------
> 
> minimal.
> 
> 
> Thanks,
> 
> Kenneth
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message