qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: Added SystemInfo::isLocalHost to check if a host name refers to the local host.
Date Mon, 07 May 2012 14:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4992/
-----------------------------------------------------------

(Updated 2012-05-07 14:34:06.921280)


Review request for qpid, Andrew Stitcher and Steve Huston.


Changes
-------

Fixes astitcher's review comments.


Summary
-------

Need by the new HA work to avoid connections to self. 
- needs windows  implementation
- doesn't cover ipv6, neither does other Url handling code at this point


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/sys/windows/SystemInfo.cpp 1335016 
  /trunk/qpid/cpp/src/tests/CMakeLists.txt 1335016 
  /trunk/qpid/cpp/src/tests/Makefile.am 1335016 
  /trunk/qpid/cpp/src/tests/SystemInfo.cpp PRE-CREATION 
  /trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp 1335016 
  /trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1335016 

Diff: https://reviews.apache.org/r/4992/diff


Testing
-------

New unit test/SystemInfo.cpp. 
make check passes


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message