qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: QPID-3603: Allow Queue::setPosition() to truncate the queue.
Date Mon, 28 May 2012 16:21:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5231/
-----------------------------------------------------------

(Updated 2012-05-28 16:21:49.489600)


Review request for qpid, Gordon Sim and Kenneth Giusti.


Changes
-------

Renamed truncate to setPosition and corrected comments.


Summary
-------

    In the new HA code a backup may sometimes be ahead of the new primary after a
    fail-over. In that case the backup truncates it's queues to the same position
    as the primary so it can continue replicating.


Diffs (updated)
-----

  /trunk/qpid/cpp/src/qpid/broker/MessageDeque.cpp 1343220 
  /trunk/qpid/cpp/src/qpid/broker/MessageMap.h 1343220 
  /trunk/qpid/cpp/src/qpid/broker/MessageMap.cpp 1343220 
  /trunk/qpid/cpp/src/qpid/broker/Messages.h 1343220 
  /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.h 1343220 
  /trunk/qpid/cpp/src/qpid/broker/PriorityQueue.cpp 1343220 
  /trunk/qpid/cpp/src/qpid/broker/Queue.h 1343220 
  /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1343220 
  /trunk/qpid/cpp/src/qpid/cluster/Connection.cpp 1343220 
  /trunk/qpid/cpp/src/qpid/ha/HaBroker.cpp 1343220 
  /trunk/qpid/cpp/src/tests/Makefile.am 1343220 
  /trunk/qpid/cpp/src/tests/QueueTest.cpp 1343220 
  /trunk/qpid/cpp/src/tests/brokertest.py 1343220 
  /trunk/qpid/cpp/src/qpid/broker/MessageDeque.h 1343220 
  /trunk/qpid/tools/src/py/.gitignore 1343220 

Diff: https://reviews.apache.org/r/5231/diff


Testing
-------

Passing make check, added unit tests to QueueTests.cpp


Thanks,

Alan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message