qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: Add log entries for correlatable broker object life cycles
Date Thu, 12 Jul 2012 14:15:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5616/#review9105
-----------------------------------------------------------


Please don't review this version: changes in progress

- Chug Rolke


On July 12, 2012, 2:38 a.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5616/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 2:38 a.m.)
> 
> 
> Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.
> 
> 
> Description
> -------
> 
> This patch adds a new log category [Configuration] and publishes a bunch of information
at info level in the format:
> [Configuration] <object> <event>, where <object> is one of Connection,
Session, Queue, Subscription, Exchange or Binding, and <event> is one of created or
closed with connection also getting a setUser.
> The bulk of the patch involves passing the necessary strings down to the object creators
so that they can emit the log.
> 
> 
> This addresses bug QPID-4079.
>     https://issues.apache.org/jira/browse/QPID-4079
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/include/qpid/log/Statement.h 1360512 
>   trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1360512 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.h 1360512 
>   trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/acl/Acl.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Link.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/broker/System.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/ha/HaBroker.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/log/Statement.cpp 1360512 
>   trunk/qpid/cpp/src/qpid/management/ManagementObject.cpp 1360512 
> 
> Diff: https://reviews.apache.org/r/5616/diff/
> 
> 
> Testing
> -------
> 
> Passes cmake test and automake make check.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message