qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request: Add log entries for correlatable broker object life cycles
Date Thu, 12 Jul 2012 18:29:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 12, 2012, 6:29 p.m.)

Review request for qpid, Alan Conway, Gordon Sim, and Ted Ross.


Logging in the generated management object classes include management id on creation and management
id and stats on destruction. This facility is implemented in the generated code:
1. A new switch "-l" is added to qmf-gen to add the logging code.
2. Automake and cmake builds specify the -l to get the code, other builds do not.
3. Object creation and destruction emit the log data without any hooks or calls from broker
calling classes.

Logging in user-specified terms is implemented by calling QPID_LOG near where raiseEvent is


This patch adds a new log category [Configuration] and publishes a bunch of information at
info level in the format:
[Configuration] <object> <event>, where <object> is one of Connection, Session,
Queue, Subscription, Exchange or Binding, and <event> is one of created or closed with
connection also getting a setUser.
The bulk of the patch involves passing the necessary strings down to the object creators so
that they can emit the log.

This addresses bug QPID-4079.

Diffs (updated)

  trunk/qpid/cpp/include/qpid/log/Statement.h 1360512 
  trunk/qpid/cpp/managementgen/qmf-gen 1360512 
  trunk/qpid/cpp/managementgen/qmfgen/generate.py 1360512 
  trunk/qpid/cpp/managementgen/qmfgen/templates/Class.cpp 1360512 
  trunk/qpid/cpp/src/CMakeLists.txt 1360512 
  trunk/qpid/cpp/src/Makefile.am 1360512 
  trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1360512 
  trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1360512 
  trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1360512 
  trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1360512 
  trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1360512 
  trunk/qpid/cpp/src/qpid/log/Statement.cpp 1360512 

Diff: https://reviews.apache.org/r/5616/diff/


Passes cmake test and automake make check.


Chug Rolke

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message