qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Review Request: QPID-4159: HA Missing messages in failover test.
Date Mon, 23 Jul 2012 16:11:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6093/
-----------------------------------------------------------

Review request for qpid and Gordon Sim.


Description
-------

QueueGuard was taking its snapshot of the initial queue range *before* it
registered its QueueObserver. That means it was possible to have unguarded messages
between the end of the snapshot and the first position protected by the guard.

Request merge to 0.18


Diffs
-----

  /trunk/qpid/cpp/src/qpid/ha/Primary.cpp 1363520 
  /trunk/qpid/cpp/src/qpid/ha/QueueGuard.h 1363520 
  /trunk/qpid/cpp/src/qpid/ha/QueueGuard.cpp 1363520 

Diff: https://reviews.apache.org/r/6093/diff/


Testing
-------

make check, ran ha_tests.py overnight in a loop


Thanks,

Alan Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message