qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Moravec (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-4139) qpid-stat -b does not show broker names anymore
Date Mon, 16 Jul 2012 10:57:35 GMT

     [ https://issues.apache.org/jira/browse/QPID-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pavel Moravec updated QPID-4139:
--------------------------------

    Attachment: qpid-stat_b-brokername.patch

Simple patch proposal.

The root cause of the bug is that qmf/console.py package has method:

  def getUrl(self):
    """ """
    return BrokerURL(host=self.host, port=self.port)

that returns an instance of BrokerURL class. This value is taken qpid-stat as:

    def displayBroker(self, subs):
..
        heads.append(Header('broker'))
        rows = []
        for broker in self.brokers:
            if self.cluster:
                ctext = "%s(%s)" % (self.cluster.clusterName, self.cluster.status)
            else:
                ctext = "<standalone>"
            row = (broker.getName(), ctext, broker.getUptime(),
..

what is not properly formatted to output in qpid/disp.py where the if-statement in:

  def formatted(self, value):
    try:
      if value == None:
        return ''

raises exception AttributeError - 'NoneType' object has no attribute 'scheme'.

I am proposing a simple patch that converts the broker.getName() to string. It fixes the original
problem though I don't know if it is not worth modifying "formatted(self, value)" method,
rather.
                
> qpid-stat -b does not show broker names anymore
> -----------------------------------------------
>
>                 Key: QPID-4139
>                 URL: https://issues.apache.org/jira/browse/QPID-4139
>             Project: Qpid
>          Issue Type: Bug
>          Components: Python Tools
>    Affects Versions: 0.14
>            Reporter: Pavel Moravec
>            Priority: Trivial
>              Labels: patch
>         Attachments: qpid-stat_b-brokername.patch
>
>
> qpid-stat -b does not show broker URL:
> # qpid-stat -b
>   Brokers
>     broker  cluster       uptime  conn  sess  exch  queue
>     =======================================================
>     ?       <standalone>  5s         1     1     8     5
> #
> It is a regression since qpid 0.7 where the URL was shown.
> A simple patch is to be proposed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message