qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rafael Schloming" <...@apache.org>
Subject Re: Review Request: SSL/TLS support for Proton connections.
Date Wed, 19 Sep 2012 16:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7171/#review11700
-----------------------------------------------------------


Minor comments notwithstanding, I think this patch is very well isolated and we should get
it on trunk ASAP and work on getting it integrated into messenger and building up some more
tests for it.

- Rafael Schloming


On Sept. 19, 2012, 4:11 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7171/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 4:11 p.m.)
> 
> 
> Review request for qpid and Rafael Schloming.
> 
> 
> Description
> -------
> 
> Patch to add SSL/TLS support to proton using OpenSSL.
> 
> 
> This addresses bug PROTON-2.
>     https://issues.apache.org/jira/browse/PROTON-2
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/examples/mailbox/README.txt 1387654 
>   /proton/trunk/examples/mailbox/fetch 1387654 
>   /proton/trunk/examples/mailbox/post 1387654 
>   /proton/trunk/examples/mailbox/server 1387654 
>   /proton/trunk/examples/mailbox/ssl-setup.sh PRE-CREATION 
>   /proton/trunk/proton-c/CMakeLists.txt 1387654 
>   /proton/trunk/proton-c/bindings/php/php.i 1387654 
>   /proton/trunk/proton-c/bindings/python/python.i 1387654 
>   /proton/trunk/proton-c/bindings/ruby/ruby.i 1387654 
>   /proton/trunk/proton-c/include/proton/cproton.i 1387654 
>   /proton/trunk/proton-c/include/proton/driver.h 1387654 
>   /proton/trunk/proton-c/include/proton/ssl.h PRE-CREATION 
>   /proton/trunk/proton-c/pn_config.h.in 1387654 
>   /proton/trunk/proton-c/src/driver.c 1387654 
>   /proton/trunk/proton-c/src/engine/engine-internal.h 1387654 
>   /proton/trunk/proton-c/src/engine/engine.c 1387654 
>   /proton/trunk/proton-c/src/ssl/openssl.c PRE-CREATION 
>   /proton/trunk/proton-c/src/ssl/ssl-internal.h PRE-CREATION 
>   /proton/trunk/proton-c/src/ssl/ssl_stub.c PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/7171/diff/
> 
> 
> Testing
> -------
> 
> "proton-tests" still works :)
> 
> Updated "mailbox" example to support SSL - see mailbox/README.txt for instructions on
how to set up and run with SSL.
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message