qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Stitcher" <astitc...@apache.org>
Subject Re: Review Request: qpid-4330 windows client hang/fault
Date Wed, 19 Sep 2012 20:42:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7179/#review11717
-----------------------------------------------------------


Minor nits follow


http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/QpidDllMain.h
<https://reviews.apache.org/r/7179/#comment25295>

    Shouldn't this be defined in the .cpp file?



http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/QpidDllMain.h
<https://reviews.apache.org/r/7179/#comment25296>

    Currently all exits return TRUE so this line is superfluous.


- Andrew Stitcher


On Sept. 19, 2012, 8:32 p.m., Cliff Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7179/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 8:32 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher, Chug Rolke, and Steve Huston.
> 
> 
> Description
> -------
> 
> This patch introduces a primitive qpid::sys::SystemInfo::threadSafeShutdown().  It always
returns true on Linux and Solaris.  On Windows, it returns true for FreeLibrary and false
if exit() has been called, main() returns, or the Qpid libraries have been statically linked.
> 
> It is used to fix the noted static destructor problems in the main Jira.
> 
> Most of the work is plumbing related to obtain knowledge of how the module is terminated
in time to be useful to the consumer of the threadSafeShutdown call.
> 
> 
> This addresses bug qpid-4330.
>     https://issues.apache.org/jira/browse/qpid-4330
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1387463

>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/CMakeLists.txt 1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/Makefile.am 1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/client/ConnectionImpl.cpp
1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/client/windows/ClientDllMain.cpp
PRE-CREATION 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/posix/SystemInfo.cpp
1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/solaris/SystemInfo.cpp
1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/QpidDllMain.h
PRE-CREATION 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/Socket.cpp
1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SystemInfo.cpp
1387463 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp
1387463 
> 
> Diff: https://reviews.apache.org/r/7179/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cliff Jansen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message