qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Darryl L. Pierce (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3633) Make cmake the primary build tool for the cpp tree
Date Mon, 22 Oct 2012 16:00:12 GMT

    [ https://issues.apache.org/jira/browse/QPID-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481452#comment-13481452
] 

Darryl L. Pierce commented on QPID-3633:
----------------------------------------

In testing the updated Cmake setup, I hit a problem with the set_target_properties macro in
amqp.make. Variables using in this macro need to be in double quotes to avoid the error:

CMake Error at src/amqp.cmake:75 (set_target_properties):
  set_target_properties called with incorrect number of arguments.

The fix is:

diff --git a/qpid/cpp/src/amqp.cmake b/qpid/cpp/src/amqp.cmake
index 7a113a8..c8da3ab 100644
--- a/qpid/cpp/src/amqp.cmake
+++ b/qpid/cpp/src/amqp.cmake
@@ -74,8 +74,8 @@ if (BUILD_AMQP)
     target_link_libraries (amqp qpidbroker qpidcommon)
     set_target_properties (amqp PROPERTIES
                            PREFIX ""
-                           COMPILE_FLAGS ${PROTON_COMPILE_FLAGS}
-                           LINK_FLAGS ${PROTON_LINK_FLAGS})
+                           COMPILE_FLAGS "${PROTON_COMPILE_FLAGS}"
+                           LINK_FLAGS "${PROTON_LINK_FLAGS}")
     install (TARGETS amqp
              DESTINATION ${QPIDD_MODULE_DIR}
              COMPONENT ${QPID_COMPONENT_BROKER})
@@ -109,8 +109,8 @@ if (BUILD_AMQP)
     target_link_libraries (amqpc qpidclient qpidcommon)
     set_target_properties (amqpc PROPERTIES
                            PREFIX ""
-                           COMPILE_FLAGS ${PROTON_COMPILE_FLAGS}
-                           LINK_FLAGS ${PROTON_LINK_FLAGS})
+                           COMPILE_FLAGS "${PROTON_COMPILE_FLAGS}"
+                           LINK_FLAGS "${PROTON_LINK_FLAGS}")
     install (TARGETS amqpc
              DESTINATION ${QPIDC_MODULE_DIR}
              COMPONENT ${QPID_COMPONENT_CLIENT})
                
> Make cmake the primary build tool for the cpp tree
> --------------------------------------------------
>
>                 Key: QPID-3633
>                 URL: https://issues.apache.org/jira/browse/QPID-3633
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Build Tools
>    Affects Versions: 0.19
>            Reporter: Justin Ross
>            Assignee: Andrew Stitcher
>
> This will serve as a tracker for the steps remaining to prepare cmake to be our primary
(and very probably only) build tool for the cpp tree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message