qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Review Request: Abstraction for SASL server role that is not tied to 0-10
Date Fri, 12 Oct 2012 16:47:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7565/
-----------------------------------------------------------

Review request for qpid, michael goulish, Ted Ross, and mick goulish.


Description
-------

The current broker::SaslAuthenticator mixes 0-10 protocol handshaking with the sasl interactions.
This patch adds a cleaner abstraction of the server role in SASL along side that already in
place for the client. This is then used in the 1.0 SASL implementation.

(Note this patch assumes and partially includes https://reviews.apache.org/r/7562/ as I could
not find an easy way to separate out commits in git into review-board compatible patches).


This addresses bug QPID-4368.
    https://issues.apache.org/jira/browse/QPID-4368


Diffs
-----

  /trunk/qpid/cpp/src/CMakeLists.txt 1397295 
  /trunk/qpid/cpp/src/Makefile.am 1397295 
  /trunk/qpid/cpp/src/qpid/NullSaslServer.h PRE-CREATION 
  /trunk/qpid/cpp/src/qpid/NullSaslServer.cpp PRE-CREATION 
  /trunk/qpid/cpp/src/qpid/Sasl.h 1397295 
  /trunk/qpid/cpp/src/qpid/SaslFactory.h 1397295 
  /trunk/qpid/cpp/src/qpid/SaslFactory.cpp 1397295 
  /trunk/qpid/cpp/src/qpid/SaslServer.h PRE-CREATION 

Diff: https://reviews.apache.org/r/7565/diff/


Testing
-------


Thanks,

Gordon Sim


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message