qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request: Expand AMQP protocol header related code to accomodate 1.0
Date Fri, 12 Oct 2012 16:51:36 GMT


> On Oct. 12, 2012, 4:42 p.m., Steve Huston wrote:
> > In ProtocolVersion.cpp should the use of the numbers 2 and 3 be replaced by the
defined constants for them?

Yes! I'll make that change.


- Gordon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7563/#review12398
-----------------------------------------------------------


On Oct. 12, 2012, 4:36 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7563/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 4:36 p.m.)
> 
> 
> Review request for qpid.
> 
> 
> Description
> -------
> 
> Mainly needed for broker side to detect the different versions and to detect if a SASL
layer has been requested.
> 
> 
> This addresses bug QPID-4368.
>     https://issues.apache.org/jira/browse/QPID-4368
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1397295 
>   /trunk/qpid/cpp/src/qpid/framing/ProtocolInitiation.cpp 1397295 
>   /trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.cpp 1397295 
> 
> Diff: https://reviews.apache.org/r/7563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message