qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: C++ Broker should not declare existing federated queues during bridge creation
Date Tue, 06 Nov 2012 21:28:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7901/#review13172
-----------------------------------------------------------


Look sensible, but what is the problem that prompted this patch? 


- Alan Conway


On Nov. 6, 2012, 7:20 p.m., Chug Rolke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7901/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 7:20 p.m.)
> 
> 
> Review request for qpid and Alan Conway.
> 
> 
> Description
> -------
> 
> This patch conditionalizes the queue declaration during bridge creation. The queue is
declared only if there is no existing queue, which is when the supplied queue name is blank.
> 
> 
> This addresses bug QPID-4423.
>     https://issues.apache.org/jira/browse/QPID-4423
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1406267 
> 
> Diff: https://reviews.apache.org/r/7901/diff/
> 
> 
> Testing
> -------
> 
> This passes federation 'make test' testing.
> 
> 
> Thanks,
> 
> Chug Rolke
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message