qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Huston" <shus...@riverace.com>
Subject Review Request: Fix for Thread object's operator bool()
Date Thu, 15 Nov 2012 03:05:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8072/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher, Chug Rolke, and Cliff Jansen.


Description
-------

The assert in QPID-4424 was a check for a Thread object not set. This change resolves that
problem, but could it really be that easy? Why doesn't the Linux code fail the same way?


This addresses bug QPID-4424.
    https://issues.apache.org/jira/browse/QPID-4424


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1409628


Diff: https://reviews.apache.org/r/8072/diff/


Testing
-------

Original reproducing test case in QPID-4424 (run broker quiet for 15 seconds). I set a breakpoint
at the assert and stepped across it without error.


Thanks,

Steve Huston


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message