qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway" <acon...@redhat.com>
Subject Re: Review Request: WIP: cluster cleanup, get rid of StatefulQueueObserver.
Date Wed, 19 Dec 2012 14:54:14 GMT


> On Dec. 18, 2012, 10:22 p.m., Andrew Stitcher wrote:
> > Goody, goody, less code to maintain!
> > 
> > I suggest removing stuff in fairly small (but consistent) chunks in case we need
to revert one of the removals for whatever reason.

Agreed. I have this in small chunks on my branch will commit as such.


> On Dec. 18, 2012, 10:22 p.m., Andrew Stitcher wrote:
> > /trunk/qpid/cpp/src/qpid/broker/Connection.cpp, line 140
> > <https://reviews.apache.org/r/8675/diff/1/?file=240798#file240798line140>
> >
> >     You've removed the comment but not changed the behaviour, that doesn't seem
right.

The test if (mgmtObject != 0) is still required although it no longer has any cluster connotation.
See the constructor, mgmtObject is set conditionally.


- Alan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8675/#review14692
-----------------------------------------------------------


On Dec. 18, 2012, 10:11 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8675/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 10:11 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Description
> -------
> 
> This is an initial pass, there is more cluster-related code that can be removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/src/qpid/acl/AclConnectionCounter.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/agent/ManagementAgentImpl.h 1423689 
>   /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.h 1423689 
>   /trunk/qpid/cpp/src/qpid/amqp_0_10/Connection.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Connection.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionState.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/DtxWorkRecord.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/DtxWorkRecord.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Link.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/MessageGroupManager.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Messages.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/broker/StatefulQueueObserver.h 1423689 
>   /trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1423689 
>   /trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1423689 
>   /trunk/qpid/cpp/src/qpid/sys/Timer.h 1423689 
>   /trunk/qpid/cpp/src/qpid/sys/Timer.cpp 1423689 
>   /trunk/qpid/cpp/xml/cluster.xml 1423689 
>   /trunk/qpid/doc/book/src/cpp-broker/AMQP-Messaging-Broker-CPP-Book.xml 1423689 
>   /trunk/qpid/doc/book/src/cpp-broker/Active-Active-Cluster.xml 1423689 
>   /trunk/qpid/doc/book/src/cpp-broker/Active-Passive-Cluster.xml 1423689 
> 
> Diff: https://reviews.apache.org/r/8675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message