qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Giusti" <kgiu...@apache.org>
Subject Re: Review Request: proton tests: add tests to exercise driver layer (Driver, Connector, and Listener objects).
Date Mon, 21 Jan 2013 17:03:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8725/
-----------------------------------------------------------

(Updated Jan. 21, 2013, 5:03 p.m.)


Review request for qpid, rajith attapattu and Rafael Schloming.


Changes
-------

Updated diff to latest trunk.

Last call - any objections?


Description
-------

This patch extends the unit tests to exercise the interfaces published by the driver layer.

It exports the necessary objects via python, and provides a simple "drain"-like server thread
for use by the unit tests.

Rational: by exposing the Driver layer to the tests, we can exercise engine and driver features
that are not exposed via the Messenger interface.  Specifically, this patch allows the unit
tests to exercise the idle timeout feature as described by AMQP 1.0, which requires access
to the engine api (transport configuration), driver (the timing-based wakeup logic) and manual
control of the client.

Rajith - not sure how much of this would need to be exposed to the Java side, if any at all.
 The Idle timeout feature may only be available on proton-c at this time.


Diffs (updated)
-----

  /proton/trunk/proton-c/bindings/php/php.i 1435340 
  /proton/trunk/proton-c/bindings/python/proton.py 1435340 
  /proton/trunk/proton-c/bindings/python/python.i 1435340 
  /proton/trunk/proton-c/src/engine/engine.c 1435340 
  /proton/trunk/proton-j/proton/src/main/scripts/proton.py 1435340 
  /proton/trunk/tests/proton_tests/common.py 1435340 
  /proton/trunk/tests/proton_tests/engine.py 1435340 

Diff: https://reviews.apache.org/r/8725/diff/


Testing
-------

Both proton-c and proton-j tests pass.


Thanks,

Kenneth Giusti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message